Solution for Pod Request Access Landing Page
Design comparison
Community feedback
- @LfrancosPosted almost 3 years ago
Hello Kirsty! this is looking really good!! Inspecting your code I was able to see a different way to solve this challenge, love the fact that you only use "margin-bottom" for the spacing between elements.
Other than that there are only two things that I would fix. -first : On mobile if you push the height of the website to be really small you will see that some information gets lost even if I try to scroll up. To fix this for the body element I would use "min-height: 100vh" instead of "height: 100vh" Second: When I start to increase the width of the webpage from mobile to tablet I feel like the content starts to stretch a little too much. The solution that I would have for that is to add a "max-width" to the "main" element. That way you can make sure it wont stretch more that what you want it to. (this is my personal preference and there is nothing wrong with what you are doing, just thought it may help a little.)
Keep-up the incredible work!!!
Marked as helpful1@KirstChatPosted almost 3 years ago@Lfrancos Thanks for the feedback Lorenzo, I really appreciate it! I'll have a look at both of those things :)
1
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord