Solution for interactive rating component
Design comparison
Solution retrospective
How can I improve my code? is my JS solution can be effecient or can be improved? Please check out my code and comment :)
Community feedback
- @Oluwafemi21Posted over 2 years ago
The only two things I noticed are the button style and the background color of the button when pressed. The submit button should have a
border:none
and the background-color of the 1-5 ratings should be grey and the hover color should be orangeMarked as helpful0@BerkePalamutcuPosted over 2 years ago@Oluwafemi21 thanks for the feedback but the background color and hover colors are already as you mentioned. I just didn't want to use given design colors. Also border: none doesn't seem like working properly on the button. Maybe you can give me another solution about it ?
0@Oluwafemi21Posted over 2 years ago@navarcus I checked your css codes and I noticed you used a lot of id's and it's not for best practices. Use classes for the second frame e.g
.thank-you-buttons
then for the button not having a border of none it's also not present in your code, try and add it and check for the result. And it's often advisable to use given design colors so the design and your own output would be close to similarMarked as helpful0@BerkePalamutcuPosted over 2 years ago@Oluwafemi21 alright I implemented the border: none and it worked. For the colors I used colorpicker and took rgb values of the given designs hex codes so they are same colors. For the id's I will turn them into classes. Thanks for the feedback. I will improve the code.
0@Oluwafemi21Posted over 2 years ago@navarcus You're welcome I would follow you on GitHub now.
Marked as helpful0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord