Solution for "fylo-dark-theme-landing-page" challenge using html/css

Community feedback

• 

  Muhammad Shajjar•1,100

  @muhammadshajjarPosted about 3 years ago

  Hello, your solution is responsive well done!

  For Form validation, you can check this or you can also refer to my solution for this.

  I have some feedback on your solution.

  • header and footer need to stay outside from main
  • It is better to wrap your whole content in a container that has max-width to avoid content to go large enough
  • Your images should have alt attribute but for decorative images, you should leave alt as blank and use role=" presentation" or aria-hidden=" true"
  • headings must go in order. So you can’t jump from h1 to h4. They are for semantic meaning, nothing to do with sizing.

  Thanks,

  Marked as helpful

  1

  ---

  

  Yousef Khalid•580

  @YousefKhalid-iqPosted about 3 years ago

  @muhammadshajjar Thank you so much for your feedback, i will get to the issues you noted above.

  0