Design comparison
Community feedback
- @SpartanFrancoPosted 3 months ago
Holaa,buen trabajo !!,me fijé que al hacer el submit con los inputs vacíos se sale del contenedor el botón de submit,porque tienes como clase md:max-h-[770px] ,entonces si sus componentes se mueven como es el caso pueden quedar fuera del main,podrías usar h-fit para que se ajuste a su contenido o aumentar el max-h para evitar ese problema ...y solo te quedaría intentar como hacer que despues de darte error los inputs al escribir en ellos el color de la fuente no sea rojo
Marked as helpful1@xStephxPosted 3 months ago@SpartanFranco Thank you for reporting me that bugs, I will fix it. If you have any other suggestions feel free to text me.
0 - @welpmozPosted 22 days ago
For some reason, the message that appears after submitting the form doesn’t disappear. I think it would be better if it automatically disappeared after a few seconds. Aside from that, great job!
1@xStephxPosted 22 days ago@welpmoz thank you for your feedback! About message and form, that is like from design, there is designed like that, and that is reason why I do like that, but your idea is also great. If you have any other suggestions, feel free to text me!
1 - @Knuckl3h3adPosted 3 months ago
Looks great! I'll do the challenge tonight haha. I'd say the only problem is margin/padding for input elements (style wise the inputted text feels too close to left border).
1@xStephxPosted 3 months ago@Knuckl3h3ad good luck in doing challenge. about margin/padding, I think it is okey but I will see again from designs, for better optimization. If you have any other sugesstions, feel free to text me!
0 - @tarachand-kPosted 3 months ago
- Font color is not correct. (provided inside style-guide.md perhaps)
- Spacing is not correct.
1@xStephxPosted 3 months ago@tarachand-k thanks for your feedback! Yeah I saw that about font color and spacing after I posted, so I will fix it. If you have any other suggestion feel free to text me!
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord