Skip to content
Submitted 7 months ago

Solution card qr

Essencell•50
@Essensity-dev
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...QR code component
  • HTML
  • CSS
1newbie

Design comparison

SolutionDesign

Solution retrospective

What are you most proud of, and what would you do differently next time?

Estoy orgullosa de haber realizado este desafio de manera rapida

What challenges did you encounter, and how did you overcome them?

centrarlo en la pagina

What specific areas of your project would you like help with?

Positions

Community feedback

  • LUKASZ-JK•10
    @LUKASZ-JKPosted 7 months ago

    General

    • Link to the github repo does not work properly. It should be "solution" while right now it is "solucion" (with a 'c').

    • README.md is empty.

    HTML

    • Attribution is commented out.

    • Text on the card is different than the one provided in the template

    • There is a section that could be moved to .css

    CSS

    • When the vertical scrollbar appears the card shifts to the left
    0
    Essencell•50
    @Essensity-devPosted 7 months ago

    @LUKASZ-JK What section could be moved to CSS?

    0
    LUKASZ-JK•10
    @LUKASZ-JKPosted 7 months ago

    @Essensity-dev It was the style section (with styles for attribution classes), but I see you have already figured it out! Keep up the good work!

    0
  • Abiona Beulah Oluwatosin•50
    @Beulah-TomiPosted 7 months ago

    The solution includes semantic HTML, it is accessible and also the layout looks good on the screen sizes.

    0

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord