Solution attempt at using Flexbox

Community feedback

• 

  Aliyu-Saidu•220

  @Aliyu-SaiduPosted almost 2 years ago

  Hi Shane Lynch, you have done a very nice job. Keep it up.

  Here are some suggestions to help you improve.

  • For proper outline structure of your website, h2 should come only after h1 and h3 should only come after h2 and so on. So you may consider replacing the h2 (or h3) you used to h1. Don't worry about the default browser font size, you can always change that with css depending on your design. Read more about accessibility here (https://web.dev/accessible/?gclid=CjwKCAiA7IGcBhA8EiwAFfUDsfX-xPDXrqqo7B0vZV44epOKlmpslZ4tepkhgjL7p6-gSKHmG7Li8RoC1_MQAvD_BwE). Or read more from the links provided above (accessibility reports).

  • Your design doesn't look good on mobile. You may wish to padding say 30px on the 'body' and remove the (margin: 30px 0) you set on the 'body'. This will give an all-round space between the screen the your design on mobile devices.

  • Also set specific height for your main Flexbox container (in this case, the body) to say 100vh. This will help to properly centralise your project on the page(vertically and horizontally).

  • If have more questions, feel free to contact me.

  Hope this is helpful? You may consider giving me an upvote and hitting the helpful button bellow.

  Happy Coding!

  Marked as helpful

  1

  ---

  

  Shane Lynch•10

  @splwdevPosted almost 2 years ago

  @Aliyu-Saidu Many thanks for the feedback, very helpful, has definitely given me points to think about!!

  0

  

  Aliyu-Saidu•220

  @Aliyu-SaiduPosted almost 2 years ago

  @splwdev you are most welcome. I am glad I could be of help. Thanks for the upvote too.

  0