Design comparison
Solution retrospective
- In your opinion, was the cod easy to understand?
- It was posible to open the layout in a smartphone properly?
Community feedback
- @AdrianoEscarabotePosted about 2 years ago
Hi Priscila Cunha, how are you? Welcome to the front-end mentor community! I really liked the result of your project, but I have some tips that I think you will enjoy:
To improve the structure of the html document, prefer to wrap all the content with the
main
tag, since this challenge is just a component, it needs amain
tag to know what the main content of the page is!Images must have alt text unless it is a decorative image, for any decorative image each IMG tag must have empty
alt=""
and addaria-hidden="true"
attributes to make all the assistive technologies of the Web, as screen reader. Learn the differences between decorative/meaningless images vs important content.To improve the code structure wrap this div:
<div class="attribution">
with the semantic tag
footer
The rest is great!
I hope it helps... 👍
Marked as helpful1@pripcPosted about 2 years agoHi @AdrianoEscarabote! Thanks a lot for your feedback and welcome! :D Your tips were really helpful!! Actually you introduce me some concepts that I didn't know, thanks for that!! I'm gonna improve my code based on your tips :D
1
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord