Abdul Khaliq 🚀• 72,620
@0xabdulkhaliq
Posted
Hello there 👋. Congratulations on successfully completing the challenge! 🎉
- I have other recommendations regarding your code that I believe will be of great interest to you.
BACKGROUND iMAGE 📸:
- Looks like the
background svgandcolorhas not been set properly, let me explain How you can easily apply thebackground colorwith thesvgthey provided.
- Add the following style rule to your css, and then experience the changes
body {
background: url(./images/pattern-background-desktop.svg), #E1E9Ff;
background-repeat: no-repeat, no-repeat;
}
- Tip, Don't forget to generate a new screenshot after editing the
cssfile
HTML 🏷️:
- This solution generates accessibility error reports, "All page content should be contained by landmarks" is due to incorrect usage of
semanticmarkup, which causes lacking of landmark for a webpage
- So fix it by replacing the
<section>element with the semantic element<footer>in yourindex.htmlfile to improve accessibility and organization of your page.
- What is meant by landmark ?, They used to define major sections of your page instead of relying on generic elements like
<div>or<span>. They are use to provide a more precise detail of the structure of our webpage to the browser or screen readers
- For example:
- The
<main>element should include all content directly related to the page's main idea, so there should only be one per page - The
<footer>typically contains information about the author of the section, copyright data or links to related documents.
- The
.
I hope you find this helpful 😄 Above all, the solution you submitted is great !
Happy coding!
Marked as helpful
0
