willprince• 20
@willprince
Posted
Great job! You nailed it!
I see 3 points of improvment.
- Fonts were giving available locally so you did not have to import via url. So if google font goes down, your font will still work.
- You do not need to set image width for the card image simply make it fit. img{ width: 100%; height: 100%; object-fit: cover; }
- Your typography is not responsive, since its the same on desktop and mobile. For font size you can use clamp(min, variableSize, max) to let the size adjust its self to the screen width.
Good job!
0
