Lucas 👾• 104,420
@correlucas
Posted
👾Hi @Gabo-boy, congratulations on your solution!👋 Welcome to the Frontend Mentor Coding Community!
Great solution and a great start! From what I saw you’re on the right track. I’ve few suggestions for you that you can consider adding to your code:
- Add the website favicon inserting the svg image inside the
<head>.<link rel="icon" type="image/x-icon" href="./images/favicon-32x32.png"> - The main heading has the tag
<h2>, in this case, you should replace it with<h1>since this heading is the main title on this page. Remember that every page should have one<h1>to declare which is the most important title and that you should follow the hierarchy using the heading sequence(h1, h2, h3, h4, h5)and never jump a level. - Clean your code by removing some unnecessary divs, most of the content can stand alone without a div. Use div only for blocks that need a special alignment or the content needs a special positioning.
- Add a margin of around
margin: 20pxto avoid the card touching the screen edges while it scales down. - Use relative units as
remoreminstead ofpxto improve your performance by resizing fonts between different screens and devices. These units are better to make your website more accessible. REM does not just apply to font size, but to all sizes as well.
Here's my solution for this challenge if you wants to see how I build it: https://www.frontendmentor.io/solutions/qr-code-component-vanilla-cs-js-darklight-mode-nS2aOYYsJR
✌️ I hope this helps you and happy coding!
Marked as helpful
0
