Solución HTML y CSS

Community feedback

• 

  P

  Noemi Gali•280

  @NomiDomiPosted almost 3 years ago

  Hey @juangin3r,

  Welcome to the world of coding! Congrats on completing the challenge!

  Looking at your solution your images do not show up. That is because you are trying to bring them in like <img src="/images/image-equilibrium.jpg". You need to specify your starting point by putting a point (.), therefore a first fix would be to change the aforementioned to <img src="./images/image-equilibrium.jpg". The point symbolizes here, which is your current folder.

  One best practice is to not specify the height of anything if possible. The height should be auto, therefore not even mentioned. It should automatically increase based on items within.

  I can see that when it comes to the width you set the initial width to 100vw which is great, but try doing that for your other components. Use percentage or other units than pixels. This will make your design responsive and won't lock stuff in place as pixels tend to do.

  For cleaner code, I would suggest to take a look at CSS variables. Here is a great video on what they are and how to use them.

  Other useful videos:

  • Are you using the right CSS units?
  • Improve your CSS by Keepin' it DRY

  Hope this helps! Keep coding! :) You are doing great!

  Marked as helpful

  0

  ---

  

  P

  Noemi Gali•280

  @NomiDomiPosted almost 3 years ago

  @NomiDomi I can see in the meantime that you fixed the image issues. :)

  Marked as helpful

  0

  

  juan manuel giner gobbi•130

  @juangin3rPosted almost 3 years ago

  @NomiDomi Hello Noemi, thank you very much for your contribution! If I change the images inadvertently when I change something else hehe so that would be and well now I'm going to see what you tell me about the css variables and finally the use of relative measures is something that I want to implement in my next projects because I It seems very important in short, thank you very much for your contribution

  1