Submitted about 1 month ago

Social links profile

AkshayAnand101• 80

@AkshayAnand101

Preview site(opens in new window)View code(opens in new window)

This is a solution for...

HTML
CSS

1newbie

View challenge

Design comparison

SolutionDesign

Solution retrospective

What are you most proud of, and what would you do differently next time?

This was my first project on frontend mentor. I learned a few new things.

What challenges did you encounter, and how did you overcome them?

I used list instead of buttons then I corrected it. Then I had to center the div and text center then used hover for buttons . I used it first timme on my own.felt good.

What specific areas of your project would you like help with?

just see and give feedback if there are any areas of development

Community feedback

Boris• 2,870

@mkboris

Posted about 1 month ago

Hi AkshayAnand101 great job completing your first challenge, here are a few things to review

Don't wrap text in empty div. Use a heading element for the name and p for the location and bio.
To improve the semantic meaning of these social media links, you should use the a (anchor) tag instead of the button tag. The a tag is used for navigation to other pages, while the button tag is designed for interactive actions like submitting forms or for events like toggling content. Also, using an unordered list ul to group the social media links is a better approach for both semantics and accessibility.
All content should be wrapped within landmarks. Wrap a main tag around the .container and a footer for the attribution.
The repo on github seems to be empty, you might want to check that

Marked as helpful

AkshayAnand101• 80

@AkshayAnand101

Posted about 1 month ago

@mkboris Thanks for the detailed feedback. I'll work on the suggestions.

Please log in to post a comment

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord