Design comparison
SolutionDesign
Solution retrospective
What are you most proud of, and what would you do differently next time?
This was my first project on frontend mentor. I learned a few new things.
What challenges did you encounter, and how did you overcome them?I used list instead of buttons then I corrected it. Then I had to center the div and text center then used hover for buttons . I used it first timme on my own.felt good.
What specific areas of your project would you like help with?just see and give feedback if there are any areas of development
Community feedback
- @mkborisPosted 3 months ago
Hi AkshayAnand101 great job completing your first challenge, here are a few things to review
- Don't wrap text in empty
div
. Use a heading element for the name andp
for the location and bio. - To improve the semantic meaning of these social media links, you should use the
a
(anchor) tag instead of thebutton
tag. The a tag is used for navigation to other pages, while the button tag is designed for interactive actions like submitting forms or for events like toggling content. Also, using an unordered listul
to group the social media links is a better approach for both semantics and accessibility. - All content should be wrapped within landmarks. Wrap a
main
tag around the .container and afooter
for the attribution. - The repo on github seems to be empty, you might want to check that
Marked as helpful1@AkshayAnand101Posted 3 months ago@mkboris Thanks for the detailed feedback. I'll work on the suggestions.
1 - Don't wrap text in empty
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord