Design comparison
SolutionDesign
Community feedback
- @mkborisPosted 3 months ago
Great work @firelordyaks, here are a few things to review
- Every page must have one Heading Element to provide a clear structure and improve readability.
- To improve the semantic meaning of these links, you should use the
a
(anchor) tag instead of thep
tag. Thea
tag is used for navigation to other pages. Also, using an unordered listul
to group the links is a better approach for both semantics and accessibility. - Use a class instead of an ID for styling to keep specificity low, reserve IDs for JavaScript manipulation.
- Consider using a modern CSS reset at the start of the styles in every project. Like this one Modern CSS Reset. This will help reset a list of default browser styles.
1 - @KharmannnPosted 3 months ago
Great effort, just need to put a class name into the first div which wrapping the content, then style it so it will have a margin-top on it, or make the <main> to be { display: flex; align-items: center; justify-content: center; }
cheers!
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord