Socials Links Profile page

Community feedback

• 

  Parves Hossain Rabby•560

  @IamparvesPosted 10 months ago

  Overall, your solution is good. However, there are some points I would like to mention for improvement.

  First, you should not use button tags for links; instead, use a (anchor) tags. Additionally, it is not always necessary to wrap elements in an extra div as you did with the name, location, and description; they could have been placed in a single div.

  Always strive to avoid using fixed width/height for elements like you did with the link items. Try to use relative units or the max-width, min-width, max-height, min-height properties.

  I also noticed that you used a grid in the links div. But you gave a column width of 100px and used padding-right of 215px to center the link items, which is definitely not a good approach. Instead, use grid-template-columns: 1fr for a single column and then use justify-items: center to center the links.

  That's all I could notice. Feel free to ask me anything; I will try to answer if I know.

  0

  ---

  

  ZionCodes1•50

  @ZionCodes1Posted 10 months ago

  @Iamparves Ok thank you so much for the review I really appreciate it and as I am a new developer Is max-width the same as width or are they different And can the max-width be used the same way as width e.g. max-width: 300px And I really need a mentor thanks if you could help me with that

  0

  

  Parves Hossain Rabby•560

  @IamparvesPosted 10 months ago

  @ZionCodes1

  max-width is related to width but not exactly the same. It's like saying that an element can be as wide as it needs to be, as long as it's less than 300px.

  To learn more you can check out this page from W3Schools: https://www.w3schools.com/cssref/pr_dim_max-width.php

  0

  

  ZionCodes1•50

  @ZionCodes1Posted 10 months ago

  @Iamparves
  Ok Thank You

  0

  

  ZionCodes1•50

  @ZionCodes1Posted 10 months ago

  @Iamparves I also want to know how to use the @media screen to make my website more responsive with both laptop website view and mobile website view

  0

  

  ZionCodes1•50

  @ZionCodes1Posted 10 months ago

  @Iamparves I also want to know how to use the @media screen to make my website more responsive with both laptop website view and mobile website view

  0

  

  Parves Hossain Rabby•560

  @IamparvesPosted 10 months ago

  @ZionCodes1

  I think it would be a little hard to explain this in the text.

  You can read some articles or watch videos on CSS Media Query. If you are unsure of which resources would be suitable, please let me know and I will try to suggest some resources.

  1

  

  ZionCodes1•50

  @ZionCodes1Posted 10 months ago

  @Iamparves Ok, pls suggest some resources. Thank you.

  0

  

  Parves Hossain Rabby•560

  @IamparvesPosted 10 months ago

  @ZionCodes1

  If you like to read:

  Media Queries

  A Complete Guide to CSS Media Queries: CSS-Tricks

  CSS media query : how to make website responsive

  Learn CSS Media Queries by Building Three Projects

  If you want to follow video guide:

  CSS Media Queries & Responsive Web Design tutorial for Beginners

  Intro to Media Queries

  Learn CSS Media Queries by Building 3 Projects

  1

  

  ZionCodes1•50

  @ZionCodes1Posted 10 months ago

  @Iamparves Thank You so much. I appreciate it

  0