social-review-card Solution

Community feedback

• 

  Adnan Ballari•145

  @itsleeparkerPosted about 3 years ago

  Thanks for the feedback dude will remember it

  0
• 

  darryncodes•6,370

  @darryncodesPosted about 3 years ago

  Hi Adnan,

  Good job, pretty much a perfect match!

  Two suggestions form me:

  • i like to use transform: translate x/y to achieve the staggered card affect instead of absolute positioning. I think it's a little simpler from a responsive design perspective
  • you could clear up your accessibility report if you changed <div class="attribution"> to <footer class="attribution"> and made your <h5> a <h2>. You shouldn't skip heading levels

  All the best!

  0
• 

  Benjo Quilario•1,810

  @benjoquilarioPosted about 3 years ago

  Hi! itsleeparker Great job on finishing this one. Everything looks great responsive well.

  Some Suggestion:

  • Remove the height: 100vh or just add the min-height: 100vh on the body tag. Because this will only limit the body to have a height 100% of the remaining viewport or screen.

  • Also remove the width: 50vh; on your body tag at media (min-width: 345px) and (max-width: 500px). Because this will only limit the body to have a width: 100% of the remaining viewport or screen.

  • Also on your <img tag> you forgot to add the alt attribute. The alt attribute provides an alternative text for an image, if the user for some reason cannot view it. In your case since the photo of image is not decorative you should add the alt attribute on it Example: alt="Colton Smith".

  aside from those everything is looks fine! Good luck

  0

  ---

  

  Adnan Ballari•145

  @itsleeparkerPosted about 3 years ago

  @benjoquilario Thankyou so much for help dude will keep that in mind 👍

  0