Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

social-proof-section-master-main

marsha 210

@Nestamash

Desktop design screenshot for the Social proof section coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


I used the pseudo-element::before inserting the star SVG. Even though I was able to accomplish that I don't feel I did that well. Is there another way I could have achieved the same results in a better way? Also, I used a lot of margins in this project for both desktop and mobile design. Is there a way I could have improved my code? Any suggestions are highly appreciated.

Thank you in advance.

Community feedback

Lucas 👾 104,420

@correlucas

Posted

👾Hello @Nestamash, Congratulations on completing this challenge!

Great code and great solution! I’ve few suggestions for you that you can consider adding to your code:

You did a really good work here putting everything together, something you can improve its your code html markup and semantics. You can replace the <div> that wraps each card with <article> you can wrap the paragraph with the quote with the tag <blockquote> this way you'll wrap each block of element with the best tag in this situation. Pay attention that <div> is only a block element without meaning.

This article from Freecodecamp explains the main HTML semantic TAGS: https://www.freecodecamp.org/news/semantic-html5-elements/

Use a CSS reset to avoid all the problems you can have with the default CSS setup, removing all margins, and making the images easier to work, see the article below where you can copy and paste this CSS code cheatsheet: https://piccalil.li/blog/a-modern-css-reset/

✌️ I hope this helps you and happy coding!

Marked as helpful

0

marsha 210

@Nestamash

Posted

@correlucas Thanks alot Lucas. From onwards I will be trying to use HTML semantic tags. Let me go through the article you've suggested for me to understand better. Thanks again, Lucas.

0

@VCarames

Posted

Hey there! 👋 Here are some suggestions to help improve your code:

  • The background images were applied incorrectly. Since they are decorative, they should be applied using the background-image property.

  • To center you content to your page, add the following to your Body Element:

body {
    min-height: 100vh;
    display: grid;
    place-content: center;
}
  • The only headings in this challenge are the "10,000+ of our users love our products." and the names of the testimonials.

  • The profile images Alt Tags need to be improved. It should state the following; “Headshot of -person’s full name-“

  • To enhance the semantics of your component, you want to wrapped each individual testimonial component in a Figure Element, the individuals information should be wrapped in a Figcaption Element and lastly, the testimonial itself should be wrapped in a Blockquote Element.

Code:

<figure>
   <figcaption></figcaption>
   <blockquote></blockquote>
</figure>

More Info:

ARTICLE

Implement a Mobile First approach 📱 > 🖥

With mobile devices being the predominant way that people view websites/content. It is more crucial than ever to ensure that your website/content looks presentable on all mobile devices. To achieve this, you start building your website/content for smaller screen first and then adjust your content for larger screens.

If you have any questions or need further clarification, let me know.

Happy Coding! 👻🎃

1

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord