Design comparison
Community feedback
- @VCaramesPosted about 2 years ago
Hey there! 👋 Here are some suggestions to help improve your code:
-
The background images are missing from your site. You will want to add them using CSS with the
background-image
property. -
The
figure
element is not being used correctly. You want to wrap the "Rated 5 Stars..." in adiv
instead. -
The profile images are not decorative. Their Alt Tags should not be blank. It should state the following; “Headshot of -person’s full name-“
-
The "Verified Buyer" is not a heading. It should instead be wrapped in a
Paragraph
element. -
The
Article
element is not the best choice for wrapping these testimonials. In order to use theArticle
element the component needs to be able to make sense on its own and be independently distributable (can be used in on another site). These testimonials cannot do neither.
You instead, want to wrap each individual testimonial component in a
Figure
element, the individuals information should be wrapped in aFigcaption
element and lastly, the testimonial itself should be wrapped in aBlockquote
element.Code:
<figure> <figcaption></figcaption> <blockquote></blockquote> </figure>
More Info:
- Your CSS Reset is extremely bare and being underutilized. To fully maximize your CSS reset, you want to add more to it.
Here are few CSS Resets that you can look at and use to create your own or just copy and paste one that is already prebuilt.
https://www.joshwcomeau.com/css/custom-css-reset/
https://meyerweb.com/eric/tools/css/reset/
http://html5doctor.com/html-5-reset-stylesheet/
If you have any questions or need further clarification, feel free to reach out to me.
Happy Coding! 🍂🦃
0 -
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord