social-proof-section-master

Community feedback

• 

  Lucas 👾•104,340

  @correlucasPosted about 2 years ago

  👾Hi Idev, congrats on completing this challenge!

  I saw your preview site and I liked a lot the work you’ve done here, it's almost complete, I’ve some suggestions you can consider applying to your code:

  The html markup for this solution its built entirely with <div>and you can improve it using semantics tags to describe what its inside each block of content. You can replace the <div> that wraps each card with <article> you can wrap the paragraph with the quote with the tag <blockquote> this way you'll wrap each block of element with the best tag in this situation. Pay attention that <div> is only a block element without meaning.

  ✌️ I hope this helps you and happy coding!

  Marked as helpful

  1

  ---

  

  Idev•200

  @IDev11Posted about 2 years ago

  Hey @correlucas Your feedback came in its time, thank you so much, I'll try to use semantics tags in the next project. Have a nice day and happy coding for you too.

  0
• 

  Adriano•38,270

  @AdrianoEscarabotePosted about 2 years ago

  Hi IDev11, how are you?

  Congratulations on completing another challenge, I really liked the result of your challenge, but I have some tips that I think you will like:

  1- id attribute value must be unique click here

  2- Document should have one main landmark, you could have put all the content inside the main tag click here

  I noticed that the content is stretching at higher resolutions, you could put a maximum width to avoid this.

  Hope it helps... 👍

  The rest is great!!

  Marked as helpful

  1

  ---

  

  Idev•200

  @IDev11Posted about 2 years ago

  Hey @AdrianoEscarabote, I am good, what about you? Yeah, TBH I did not notice that when I was working lol, I will fix that ID problem right now. I can not believe I forgot that main tag again hahaha, excuse me bro, I do not know what is going on with me. Thank you so much for your helpful feedback, I will work with the tips that you gave me! Have a nice day.

  0

  

  Adriano•38,270

  @AdrianoEscarabotePosted about 2 years ago

  @IDev11 hahahhah no problem, happy coding!!

  1