Design comparison
Solution retrospective
challenge accepted!
feel free to comment and give your feedback :)
Community feedback
- @ApplePieGiraffePosted almost 4 years ago
Hi, Iqbal! 👋
Good work on this challenge! 😀 Your solution looks pretty good! 👍
I suggest,
- Adding a little space between the stars and the review text in the review boxes when the stars are positioned on top of the review text.
- Decreasing the size of the heading (and perhaps even of the paragraph text a bit) in the mobile layout of the site because they do not need to be so big, then.
Keep coding (and happy coding, too)! 😁
1@Firdausi-IqbalPosted almost 4 years ago@ApplePieGiraffe Thanks Apple for the suggestions, will do try to modify the solutions and implement your suggestions (happy coding for you as well) 😁
0 - @grace-snowPosted almost 4 years ago
Hi Iqbal
Viewing on mobile some content is hidden or squished for me. This is because you're using percentages on the grid-template-rows. If you changed these to be auto or even min-max it would be fixed I think.
If you change this you'll probably find you don't need as many media queries on this. I would only expect one or max 2 to create a design like this.
Im sure you're aware already your bottom three cards aren't aligned like the design on desktop either, so maybe look at that too.
Good luck with it! And please upvote if you've found any of this helpful ☺
1@Firdausi-IqbalPosted almost 4 years ago@grace-snow thanks grace for your feedback, basically i use the percentages to get more control on the grid column row. But it turn out pretty bad 😂
Will do try to fix this, thank you once again
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord