Social-Proof-Section

Community feedback

• 

  T

  ApplePieGiraffe•30,545

  @ApplePieGiraffePosted almost 3 years ago

  Hello there, Qstar12! 👋

  Nice work on this challenge! 🙌 Your solution looks good and is responsive! 👍

  A couple of things I suggest are,

  • Adding min-height: 100vh to the body to ensure that it is always at least as high as the viewport (that'll prevent there being any empty white space at the bottom of your solution on extra-large screens).
  • Perhaps adding a little bit more padding around the sides of the main content of the page in the desktop and tablet layouts (the content just seems a bit close to the screen as the size of the screen decreases).
  • You probably don't need to add aria-hidden to the element that contains the star icons since you have left their alt text empty (since that will keep screen readers from mentioning those images, in the first place). 😉

  Hope you find these couple of tips a bit helpful. 😊

  Keep coding (and happy coding, too)! 😁

  1

  ---

  

  Qstar12•70

  @Qstar12Posted almost 3 years ago

  @ApplePieGiraffe thanks for you informative feedback. I like to call it feed forward. 👍🏿

  Your suggestions have been noted 📝 there's actually a few additional areas I'd add padding too. Also the ratings are a little off. I'll continue to learn and grow from feedback like you. 👏🏿

  1