Social-proof-section

Community feedback

• 

  hardy•3,660

  @hardy333Posted about 3 years ago

  Hi, first of all nice solution. You have done better job then 99% percent of people how completing it ... But obviously there are some issues ...

  • I suggest to remove margin-left on dark pink cards and gave them left margin instead except for first one, or just remove right margin from last one it is up to you and the reason for that is this <---...

  • use line-height property to gave more space to paragraphs I suggest to use line-height: from 1.3 to 1.6 ... which works best for this case.

  • Also color or font size on cars is not exactly the same as design images so try to change them little bit .

  Marked as helpful

  4

  ---

  

  Juveria Dalvi•1,375

  @Juveria-DalviPosted about 3 years ago

  @hardy333 okay I'll do it Thank you but I don't get you which left margin you are trying to say here 🤔

  0
• 

  Muhammad Shajjar•1,100

  @muhammadshajjarPosted about 3 years ago

  Hi, Well done!

  • I think in Testimonials images your alt needs only the person name, Instead of using Anne Wallace image here , Avoid adding those words that relates to graphics such as logo, image , and for decorative images it is better to leave alt="" , and use aria-hidden="true" or role="presentation". In your case it is better to not give stars any alt attribute.
  • Try to use box-sizing:border-box, The box-sizing property allows us to include the padding and border in an element's total width and height. It will make sure that those elements don't add additional size when you add padding and border.
  • For the testimonial quote, I recommend to use block-quote for more semantic HTML check out this for more information
  • Instead of going for width try to go for max-width if needed. Writing fixed things would cause issues.
  • use rem or sometimes em instead of using px because the size of the pixel isn't always the same.
  • We all use border for making our layouts , but if your code is good to go, it is good practice to remove those code which only helps ourself instead of commenting it.

  I hope that helps , good luck

  Marked as helpful

  0