Social-Proof-Section: HTML, CSS, Google Fonts

Community feedback

• 

  Vanza Setia•27,775

  @vanzasetiaPosted about 3 years ago

  👋Hi Heather Smith!

  👍 Good job on completing this challenge!

  I have some feedback on this solution:

  • For any decorative images, like in this case the star icons, you should leave the alt="" empty and add aria-hidden="true" or role="presentation" to make sure that all screen readers will ignore those icons.
  • Rated 5 Stars in..., should not be headings. Heading tag is used to titling a section. Use strong tag instead.
  • The name, status, and the testimonial, should not be a heading. For the name and status, you can use p tag. For the testimonial, I recommend to use blockquote.

  <section id="cardholder">
          <section class="card" id="colton">
            <img src="./images/image-colton.jpg" alt="colton's avatar image" class="avatar">
            <section class="namebuyer">
              <h3>Colton Smith</h3>
              <h4>Verified Buyer</h4>
            </section>
            <h5>"We needed the same printed design as the one we had ordered a week prior.
            Not only did they find the original order, but we also received it in time.
            Excellent!"</h5>
          </section>
  

  • Also, in my opinion, it would be much better if each card is a list item. So, I recommend to use ul as the parent and for each card, wrapped the content with li.
  • For the attribution, I recommend to use footer instead of a div.

  Now for the CSS:

  • Try to add padding-top and padding-bottom on your body element to prevent the h1 touching the top edge of the browser (mobile view 360px * 640px).
  • Use rem or sometimes em unit. Using px will prevent the user from controlling the size of your page.

  That's it! Hopefully this is helpful!

  Marked as helpful

  1
• 

  Aakash Verma•6,710

  @skyv26Posted about 3 years ago

  Wow! Nice Work... I think it is ok, I mean your design is not perfect but still looking similar.

  1

  ---

  

  Heather Smith•220

  @sorengreyPosted about 3 years ago

  @skyv26 Thank you! That's nice to hear after a long struggle, lol!

  1