Design comparison
Solution retrospective
Feedback will be helpful
Community feedback
- @milosshomyPosted about 2 years ago
Hey Itaro, congratulations on finishing this challenge. As I can see your HTML is fine, but you can improve it by using proper tags. For example your <div> with a class of ".deck" could be an <article> and your <p> tag with a class of ".description" could be a <blockquote> tag. https://www.w3schools.com/tags/tag_article.asp https://www.w3schools.com/tags/tag_blockquote.asp
I hope this helps!
Marked as helpful1 - @correlucasPosted about 2 years ago
👾Hello @Itaro18, Congratulations on completing this challenge!
Great code and great solution! I’ve few suggestions for you that you can consider adding to your code:
1.You’re in the right track I can see that you’ve used the majority semantic tags possible for this challenge, the only block you’ve missed is the paragraph containing the
quote text
you can improve the accessibility there using<blockquote>
to indicate to screen readers that the content inside that paragraph is a quote. 2.Use a CSS reset to avoid all the problems you can have with the default CSS setup, removing all margins, and making the images easier to work, see the article below where you can copy and paste this CSS code cheatsheet: https://piccalil.li/blog/a-modern-css-reset/✌️ I hope this helps you and happy coding!
1
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord