Design comparison
Solution retrospective
my first attempt at this . i used css grids. because i am eye-balling all the padding and margins, its very tedious to get the correct spacing.
Please suggest an application i can use to measure padding and margins.
As always, please feel free to give your positive critique
Community feedback
- @DrallasPosted over 3 years ago
Hey Yusuf
Just completed this one myself too.
- Your CSS structure is very nice, but too many !importants! (i used 0 importants) :)
- Your BG images are not showing up, the url for GH pages is without fw slash!
- Your Sizing is a bit off / bigger than the design.
- Also the positioning is a bit off.
I hope it helps and you can refactor it a bit..
Greetings.
0@YusufWebDevPosted over 3 years ago@Drallas
im not using the pro version. so im new to guessing sizes for the margins and padding. can you recommend an application i can download to measure the margins. what software are you using.
0@DrallasPosted over 3 years ago@YusufWebDev I can recomment the video's from (Coder Coder) Jessica https://www.youtube.com/watch?v=8w_kHIAkucA she uses Adobe XD and a simple overlay to measure from jpeg.
If you watch her video's you will see what i mean!
0 - @imslaygalPosted over 3 years ago
We're all eyeballing :) Even the experts. That's why I love to watch them FM projects on Youtube bc we realize they're just like us.
0@YusufWebDevPosted over 3 years ago@imslaygal
i agree. it just makes things so much more complicated.
0
Please log in to post a comment
Log in with GitHub
Join our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord