Social-proof-section

Community feedback

• 

  T

  ApplePieGiraffe•30,545

  @ApplePieGiraffePosted about 3 years ago

  Hey there, CWu! 👋

  Nice job on this challenge! 👏 Your solution looks pretty good in the desktop layout. 😀

  I'd like to suggest,

  • Replacing the alt text of the star icon images with an empty string (""). That's because if you leave the alt text there, screen readers will read out the text for every star icon, which is unnecessary and might be kind of annoying. In this case, the star icons are not essential to the content of the page, so I think they can safely be excluded from the stuff read by screen readers.
  • Removing some of the margin around the container that contains most of the elements of the page in the mobile layout. If you'd like to add some space between the elements of the page and edges of the screen, I think using padding instead would be an easier way to do so, since that will add space inside the container (not outside of it).
  • Using flexbox rather than CSS grid to layout the testimonial boxes might make things a little easier for you. Simply use a media query to change the flex-direction property of the flex container from column to row for the desktop layout.

  Hope those few tips are helpful. 🙂

  Keep coding (and happy coding, too)! 😁

  0

  ---

  

  CWu•270

  @cwu90Posted about 3 years ago

  @ApplePieGiraffe Thanks for the great tips! 😁

  0