Design comparison
SolutionDesign
Solution retrospective
I would love any and all feedback on this challenge, from the overall look to the code itself. Please let me know if there is any code that is unnecessary or could have been shorten somehow. Thanks, and have a great week!
Community feedback
- @juanpb96Posted over 2 years ago
Hey Kim! 👋
Your solution looks good! 🥳
I have some tips for you to improve your project:
- I think you can change your
div class="attribution"
tofooter class="attribution"
this way you add a more semantic tag in your HTML 😉 - I'm not sure why you used
display: flex
in your body but this is causing two columns, so the layout looks a bit weird. - Stars in
.review
are using inline styles, I consider you can include a class or play with selectors to easily add the margin that you need. Maybe something like.review > img { margin-right: 9px }
could work.
Hope this helps! 😃
Marked as helpful0 - I think you can change your
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord