social-proof

Community feedback

• 

  Abdul Khaliq 🚀•72,560

  @0xabdulkhaliqPosted over 1 year ago

  Hello there 👋. Congratulations on successfully completing the challenge! 🎉

  • I have other recommendations regarding your code that I believe will be of great interest to you.

  ---

  HTML 🏷️:

  • This solution generates accessibility error reports, "All page content should be contained by landmarks" is due to incorrect usage of semantic markup, which lack landmark for a webpage

  ---

  • So fix it by replacing the <article> element with the semantic element <main> in your index.html file to improve accessibility and organization of your page.

  ---

  • What is meant by landmark ?, They used to define major sections of your page instead of relying on generic elements like <div> or <span>

  ---

  • They convey the structure of your page. For example, the <main> element should include all content directly related to the page's main idea, so there should only be one per page

  ---

  HEADINGS ⚠️:

  • This solution has generated accessibility error report due to skipping heading levels

  ---

  • We want to avoid skipping heading levels, make sure to start with <h1> and working your way down the heading levels (<h2>, <h3>, etc.) helps ensure that our document has a clear and consistent hierarchy. Read more 📚

  ---

  • Because skipping heading levels is a poor practice from the perspective of information design, whether we are talking about web pages, books, journal articles, or about anything else. You can not only confuse screen readers but all readers when you don't follow a consistent, logical pattern with your heading structure.

  ---

  .

  I hope you find this helpful 😄 Above all, the solution you submitted is great !

  Happy coding!

  Marked as helpful

  0
• 

  Finney•3,030

  @Finney06Posted over 1 year ago

  Hello Musa 👋. Good job on completing the challenge !

  Here are some suggestions regarding your code that may be of interest to you.

  HTML 🏷️:

  To clear the Accessibility report:

  The error message "ul and ol must only directly contain li, script, or template elements" typically appears when there is invalid HTML markup in the code. This error indicates that either an <ul> or <ol> element contains an element other than <li>, , or <template> elements as direct children.

  • If you need to include other types of elements within a list, you can nest them within an <li> element.

  • Use a validator tool to check your HTML code for other possible errors.

  Here's an example of valid HTML markup for an ordered list:

  <ol>
    <li>Item 1</li>
    <li>Item 2</li>
    <li>Item 3</li>
  </ol>
  

  And here's an example of valid HTML markup for an unordered list:

  <ul>
    <li>Item 1</li>
    <li>Item 2</li>
    <li>Item 3</li>
  </ul>
  

  By ensuring that your HTML markup follows the specifications, you can avoid errors and ensure that your web page is accessible to all users.

  • The error message "All page content should be contained by landmarks" typically appears when the HTML code does not contain the necessary accessibility landmarks to help users navigate the content of the page. In this case, the <div> element with class "attribution" is not a landmark or a footer element, and therefore it does not provide any navigation aid for users.

  To fix this error, you can do the following:

  • Use HTML5 landmarks: HTML5 introduced several new elements that can be used to define the different sections of a web page, such as <header>, <nav>, <main>, <aside>, and <footer>. By using these elements, you can create a clear hierarchy of content that is easy to navigate for users.

  • Include a footer element: A footer element should be included at the end of the document and contain information about the website or document, such as copyright information or contact details.

  Here is a [**web accessibility evaluation tool**](https://wave.webaim.org/)📕 to check your webpage for any remaining errors or warnings related to landmarks.
  
  I hope you find it helpful!😏 Above all, the solution you submitted is 👌.
  🎉Happy coding!
  

  Marked as helpful

  0