social-media-dashboard-with-theme-switcher

Community feedback

• 

  Yemisrach•1,430

  @Yemisrach15Posted about 2 years ago

  Hi Amer, great job! This is how I approach dark/light theme switch too :) Here are a few suggestions of mine,

  • The theme toggle button is not accessible to keyboard users and other assistive technology users. I can't focus on the button when I tab through your page. So you need to change it to, for instance, a checkbox input, link the input to a label, style the label to look like the design and hide the default checkbox input. Clicking on the label is like clicking on the checkbox.
  • Wrap the section after the header with main tag.
  • Avoid adding unnecessary elements in the HTML as in the span the top horizontal bar on the cards. You can use pseudo elements as an alternative.
  • You should have only one h1 heading per page. It's what identifies the main title of your page so more than one title creates confusion.
  • The social media icons as well as the up and down icons should have an alt text as they contribute to the meaning of the cards' content.
  • The overview-today section is part of the main content of the page so it should be inside main. But you can put the .attribution in a footer element.

  Keep up the great work

  Marked as helpful

  0

  ---

  

  a•370

  @Mrcode93Posted about 2 years ago

  @Yemisrach15 thank you for your suggestion its a helpful thing.

  0