social-media-dashboard responsive using Media Query, Grid and JS

Community feedback

• 

  Emmanuel Daniel•1,170

  @coderdanniePosted over 1 year ago

  Hi. Congrats on the completion of this project. An extra features you can add is to store the themes state using browser localstorage so that your site can maintain the theme state even if the page was reload. Right now if I switch to light mode and reload the web page its switching back to the default theme. Using browser storage to store the theme and accessing the themes based on user preference will prevent this from happening. https://developer.mozilla.org/en-US/docs/Web/API/Window/localStorage

  Marked as helpful

  0
• 

  Abdul Khaliq 🚀•72,560

  @0xabdulkhaliqPosted over 1 year ago

  Hello there 👋. Congratulations on successfully completing the challenge! 🎉

  • I have other recommendations regarding your code that I believe will be of great interest to you.

  BUTTONS 🖲️:

  • This solution had generated accessibility error reports due to lack discernible text for <button> element

  ---

  • The <button> must have discernible text that clearly describes the destination, purpose, function, or action for screen reader users.

  ---

  • Screen reader users are not able to discern the purpose of elements with role="link", role="button", or role="menuitem" that do not have an accessible name.

  ---

  • The <button> name rule has five markup patterns that pass test criteria:

  
  <button id="al" aria-label="Name"></button>
  
  <button id="alb" aria-labelledby="labeldiv"></button>
  
  <div id="labeldiv">Button label</div>
  
  <button id="combo" aria-label="Aria Name">Name</button>
  
  <button id="buttonTitle" title="Title"></button>
  
  

  • Ensure that each <button> element and elements with role="button" have one of the following characteristics:

    • Inner text that is discernible to screen reader users.
    • Non-empty aria-label attribute.
    • aria-labelledby pointing to element with text which is discernible to screen reader users.
    • role="presentation" or role="none" (ARIA 1.1) and is not in tab order (tabindex="-1")

  ---

  .

  I hope you find this helpful 😄 Above all, the solution you submitted is great !

  Happy coding!

  0