Social-Links-Profile-Main

Community feedback

• 

  T

  Grace•31,270

  @grace-snowPosted 10 months ago

  Hi here is some feedback

  1. All page content should be contained within landmarks. Every page at least needs a main. The attribution should be in a footer
  2. Only the person's name is a heading in this. There is no h2 or h3. Those are just paragraphs
  3. Personally I think the image is meaningful content and should have an alt description
  4. All of the links in this are links, not buttons in my opinion. I think they would navigate somewhere
  5. The order of the head matters for performance and for SEO. The title should be high up before anything like style links
  6. It is better for performance to link fonts in the html head instead of css imports.
  7. In css always use a modern css reset at the start of the styles in every project. Andy Bell has a good one you can look up and use.
  8. The component must not have a width. Instead, use max-width in rem. This means it will look as it should for all users no matter what device or base font size they use.
  9. Does the text container need to be a flex column? Block elements will stack by default. It's fine to use a flex column if you want, but there's no benefit unless you're planning to use gap perhaps.
  10. Font size must never be in px
  11. Use the colors in the style guide, not keywords like grey
  12. Removing outline from interactive elements is an immediate and critical accessibility failure. It makes sites completely inaccessible to keyboard users in one line of css.

  Marked as helpful

  1

  ---

  

  William•190

  @tuaPuan83Posted 10 months ago

  Thank you so much for feedback.@grace-snow

  0