social-links-profile-main

Community feedback

• 

  Daniel 🛸•44,310

  @danielmrz-devPosted 10 months ago

  Hello @uragunz16!

  Your solution looks great!

  I have a suggestion for improvement:

  • Use <main> to wrap the main content instead of <div>.

  📌 Tags like <div> and <span> are typical examples of non-semantic HTML elements. They serve only as content holders but give no indication as to what type of content they contain or what role that content plays on the page.

  This tag change does not impact your project visually and makes your HTML code more semantic, improving SEO optimization as well as the accessibility of your project.

  I hope it helps!

  Other than that, great job!

  Marked as helpful

  0

  ---

  

  Mark Owen Policarpio•30

  @uragunz16Posted 10 months ago

  @danielmrz-dev hello Thank you again for helping me. And now I'm using <main></main>

  <section></section> and <footer></footer> with my newly challenge recipe-page-main.

  1
• 

  Olaniyi Ezekiel•7,580

  @Ezekiel225Posted 10 months ago

  Hello there 👋 @uragunz16.

  Good job on completing the challenge !

  Your project looks really good!

  I have suggestions about your code that might interest you.

  Consider adding a min-height of 100vh to the body element so as to centralize your project.

  body { 
    min-height: 100vh;
    align-items: center;
    display: flex;
    justify-content: center;
  }
  
  

  I hope it helps!

  Other than that, great job!

  Happy coding.

  Marked as helpful

  0

  ---

  

  Mark Owen Policarpio•30

  @uragunz16Posted 10 months ago

  hello @Ezekiel225 I'm so glad you feedback and for your code. It's help me haha ^_^ Thank you!.

  0

  

  Mark Owen Policarpio•30

  @uragunz16Posted 10 months ago

  @Ezekiel225 it's looks good haha thank again!! .. happy coding!

  0