social-links-profile

Community feedback

• 

  Rebecca Padgett•1,840

  @bccpadgePosted 10 months ago

  Hello @Ali-AK004. Congratulations on completing this challenge!!!🎉

  I have a few tips to improve your solution below.

  HTML 📃:

  • Image should have alt text <img src="assets/images/avatar-jessica.jpeg" alt="headshot of Jessica Randall" /> for screen readers

  CSS 🎨:

  • Font size shouldn't be in pixels because pixels don't scale when users want to change their font size in preferred browser.
  • I see you used pixels and rem units in your stylesheet and would be to stick to rem units.

  Here is a pixels to rem converter

  You can also implement the DRY principle which means Don't Repeat Yourself on img, span, and a have the same style; you can do this

  img, span, a{
  display: block;
  }
  

  Here is my solution to this challenge - Social links profile

  I hope you find this useful and don't hesitate to reach out if you have any questions

  2