Social-links-profile Public

Community feedback

• 

  Daniel 🛸•44,310

  @danielmrz-devPosted 9 months ago

  Hello @hgcfkuyfliyfl!

  Your solution looks great!

  I have a couple of suggestions (about semantic HTML) for improvement:

  📌 First: Use <main> to wrap the main content instead of <div>.

  Think of <div> and <span> in HTML like plain boxes or placeholders. They're handy for holding content, but they don't tell us anything about what's inside or what it's meant for on the webpage.

  📌 Second: Use <h1> for the main title instead of <h2>.

  Unlike what most people think, it's not just about the size and weight of the text.

  • The <h1> to <h6> tags are used to define HTML headings.
  • <h1> defines the most important heading.
  • <h6> defines the least important heading.
  • Only use one <h1> per page - this should represent the main heading/title for the whole page. And don't skip heading levels - start with <h1>, then use <h2>, and so on.

  All these tag changes may have little or any visual impact but they make your HTML code more semantic and improve SEO optimization as well as the accessibility of your project.

  I hope it helps!

  Other than that, great job!

  0
• 

  Davide•330

  @deedeedevPosted 9 months ago

  Hi @hgcfkuyfliyfl , nice job! If you want to position the card at the center without setting a fixed height you can put it inside a div container and center it with flex, like this:

  .container: {
    width: 100%;
    min-height: 100dvh;
    display: flex;
    justify-content: center;
    align-items: center;
  }
  
  .card {
    min-width: 350px;
  }
  

  Using min-width, max-width, min-height and max-height instead of fixed values makes your design more flexible and responsive. In most cases I try to avoid using percent values when setting width/height, you easily get weird outcomes on very large or very small screens. A better approach in my opinion is using media queries and adapt your max-width and min-width according to the screen size. You might also want to look into container queries: using them you can write media-queries that are based on the container size instead of the screen size.

  Hope this can be helpful!

  0