Social-links-profile

Community feedback

• 

  Daniel 🛸•44,310

  @danielmrz-devPosted 10 months ago

  Hello @salmiahmedyacine!

  Your solution looks excelent!

  I have just one suggestion:

  📌 In order to make your HTML code more semantic, don't skip heading levels - start with <h1>, then use <h2>, and so on.

  Unlike what most people think, it's not just about the size and weight of the text.

  • The <h1> to <h6> tags are used to define HTML headings.
  • <h1> defines the most important heading.
  • <h6> defines the least important heading.
  • Only use one <h1> per page - this should represent the main heading/title for the whole page.

  All these tag changes may have little or any visual impact but they make your HTML code more semantic and improve SEO optimization as well as the accessibility of your project.

  I hope it helps!

  Other than that, great job!

  Marked as helpful

  0
• 

  Adeel Atta•130

  @AdeelAttaPosted 10 months ago

  Button hover effect is not same as described in design hover with green color.

  0
• 

  Hassan Moataz•1,860

  @hassanmoaaPosted 10 months ago

  Hello @salmiahmedyacine!

  Great Job solving the challenge mate *congrats * 🎉

  I have some suggestions for improvement!

  Heading is defined with <h1> to <h6> tags. It is important to use headings to show the HTML document structure.

  <h1> headings should be used for main headings, followed by <h2> headings, then <h3>, and so on up to <h6>.

  ➖➖➖➖➖

  • Use <main> to wrap the main content instead of <div>.

  📌 Tags like <div> and <span> are typical examples of non-semantic HTML elements. They serve only as content holders but give no indication as to what type of content they contain or what role that content plays on the page. This tag change does not impact your project visually and makes your HTML code more semantic, improving SEO optimization as well as the accessibility of your project.

  Other than that Perfect!

  0