Design comparison
Solution retrospective
BEM, hover
What challenges did you encounter, and how did you overcome them?During the development process, there was a problem with understanding links to social network profiles. An attempt to use a BEM did not allow us to make the hover correctly. Links in this case should not be treated as buttons, otherwise there will be a conflict in the css.
What specific areas of your project would you like help with?practice)
Community feedback
- @Samir22RajPosted 8 months ago
The code seems to be clean, and the application of BEM and hover is no small feat.
I would like to point out the obvious spacing and vertical alignment of the main element. I noticed that hover is only working for one specific element though (the github profile link). A quick solution to that would be to assign a common class to all the link tags and adding the hover effect on the said class. In fact, you could style using the common class instead as there are actually no modifications needed in the list of profile links.
0@2lanaPosted 8 months agoHi, @Samir22Raj! Thanks for your feedback. Indeed, the hover is done only for one element. Your solution idea is very helpful)
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord