Social-links with Tailwind

Community feedback

• 

  T

  Grace•31,270

  @grace-snowPosted 9 months ago

  Hi

  You don't need to use any extension. Here are some important bits of feedback...

  1. Please be sure to Indent the code consistently so it's easier to read and spot bugs. Your code editor can even do this formatting automatically for you with prettier.
  2. This is a list of links. So you should be using a list element. Make sure you carefully consider the appropriate html elements for the content in each design. It's a really important skill to develop.
  3. It is better for performance to link fonts in the html head.
  4. The image is meaningful content so should have alt text. Read the excellent post in the resources channel on discord about how to write good alt text for an example.
  5. Node modules must never be pushed up to github!! It should be in the git ignore. Delete it. Packages are built at the point of deployment.
  6. Never limit the height of elements that contain text, including the body. Min height is fine. Height is definitely not.
  7. I would expect the image in this to have an explicit width and height.

  Marked as helpful

  1
• 

  Daniel 🛸•44,310

  @danielmrz-devPosted 9 months ago

  Hello there! 🙋🏽‍♂️

  Your solution looks excellent!

  I have a suggestion about your code that might interest you:

  📌 If you don't have the Figma design files, I recommend using a browser extension called Perfect Pixel.

  It allows you to compare your finished project with the design images that come along when you download the project and check the (almost exact) dimensions. It's very useful!

  I hope it helps you in future projects! 😊

  Other than that, great job!

  1