SocialLinkProfile

Community feedback

• 

  KapteynUniverse•2,170

  @KapteynUniversePosted 29 days ago

  BEM looks about right. There isn't right or wrong for BEM i believe, just don't overdo it like:

  <article class="card">
      <header class="card__header">
          <h2 class="card__header__headline"></h2>
      </header>
  </article>
  

  More importantly that buttons are probably are links of the Jessica's socials. So instead of divs, using anchor tags with unordered list would be better. Like:

     <ul>
              <li><a href="...">...</a></li>
              <li><a href="...">-...</a></li>
              <li><a href="...">...</a></li>
              <li><a href="...">...</a></li>
              <li><a href="...">...</a></li>
     </ul>
  

  Instead of pixels em/rem units are better for responsiveness. I recommend you to check Kevin Powell's this video for better understanding.

  Marked as helpful

  1

  ---

  

  Siyaaan•40

  @SiyaaanPosted 29 days ago

  @KapteynUniverse

  Thank you very much for your feedback, I'm so much focused on css that I almost forgot some of html elements. I'll keep this in mind.

  1
• 

  Adriano•38,330

  @AdrianoEscarabotePosted 29 days ago

  Hi Siyaaan, how are you doing? I really loved the outcome of your project, but I have a few suggestions that I think might be helpful:

  To enhance the semantics of your code, consider using a <ul> (unordered list) for the collection of links, as it represents a list of related items. Here's an example:

  <ul>
      <li><a href="#">GitHub</a></li>
      <li><a href="#">Frontend Mentor</a></li>
      <li><a href="#">LinkedIn</a></li>
      <li><a href="#">Twitter</a></li>
      <li><a href="#">Instagram</a></li>
  </ul>
  

  Using a <ul> provides clear structure and context, signaling to both browsers and assistive technologies that these links are part of a cohesive group, improving both accessibility and readability.

  The rest is excellent.

  I hope you find it useful. 👍

  1