social-link-1

Hello there 👋. Congratulations on successfully completing the challenge! 🎉

• I have a suggestion regarding your code that I believe will be of great interest to you.

HTML 🏷️:

• This solution may cause accessibility errors due to lack of semantic markup, which causes lacking of landmark for a webpage and allows accessibility issues to screen readers, due to accessibility errors our website may not reach its intended audience.

• Landmarks are used to define major sections of your page instead of relying on generic elements like <div> or <span>. helps us to provide a more precise detail of the structure of our webpage to the browser or screen readers

• So resolve the issue by replacing the <div class="attribution"> element with the proper semantic element <footer> in your index.html file to improve accessibility and organization of your page

• Additionally there's a small typo in your CSS,

.page-wrap {
  width: 100%;
  min-height: 100hv;
}

• You need to declare 100vh not 100hv so that your component is properly centered and also removing the width: 100% is a good move because div is block level element so it will consume entire width of page by default. So we don't need to explicitly do it.

.

I hope you find this helpful 😄 Above all, the solution you submitted is great !

Happy coding!