social-link

Community feedback

• 

  mircodev•60

  @mircodgPosted 6 months ago

  Hi @alfanarifian, congratulations for your solution. I would give you some best practice tips for both html and css.

  In css is best to have a reset because any html attribute comes with default css properties. In order to be more consistent with box sizing and overall layout you can put the following code at the start of your css file:

  *{
      margin:0; 
      padding:0; 
      box-sizing: border-box;
  }
  

  If can also set the font family inside of it. Then for the html I suggest to use semantic tags like <header> , <main>, <footer>, and so on. Also try to do all the styling on the style.css and avoid doing so in the html for code readability.

  Other than that I think you did a really good job.

  0

  ---

  

  alfanarifian•20

  @alfanarifianPosted 6 months ago

  @mircodg I think that is good for me. Because, I don't know about that before. Thank's for your attention in my code, i will try it to practice your tips later. I hope my code to be cleaner in the future

  0