social sharing

Community feedback

• 

  T

  Chamu•13,340

  @ChamuMutezvaPosted 4 days ago

  Hi Molokwu wilson

  Nice work so far on the challenge. Here is my opinion:

  1. missing landmark elements - this challenge needs the main landmark element. Landmark elements are important for providing means to identify the organization and structure of a web page. The main element identifies the primary content of a web page
  2. the path of your image should be easier to follow . Generally path names should not have the empty spaces and the name does not have to be that long. That will be prone to errors
  3. an interactive element should not be a parent or child of another interactive element. A button cannot have an anchor element as a child or vice-versa. A button is associated with form submission and toggling a menu whilst the anchor element is tied to navigation
  4. Always have a modern reset stylesheet to normalise your site
  5. the max-height: 100vh; on your body element is not diserable , it can have some effects. Instead what you need is min-height: 100vh; - this allows you content to grow without restriction when necessary
  6. Font sizes should never be in px values, use rem. The following article can help you on that topic font sizes

  0
• 

  Shruti Akkewar•50

  @shrutiakkewarPosted 4 days ago

  The container is centered properly, but responsiveness should be checked for smaller screens.

  Add a max width of 90% to the container to ensure it scales down for smaller devices.

  The buttons and text look closely packed. Add more padding and margin between buttons and text for better spacing.

  .container button {

  margin: 10px 0; /* Increased margin */

  padding: 12px; /* Larger padding */

  }

  You did a great job!...

  Happy Codding!!!

  0