Design comparison
Solution retrospective
I am currently learning CSS grid and BEM methodology. Any feedback that can help me improve my skills is welcome.
Community feedback
- @correlucasPosted about 2 years ago
👾Hello @vjeanty02, Congratulations on completing this challenge!
Great code and great solution! I’ve few suggestions for you that you can consider adding to your code:
You did a really good work here putting everything together, something you can improve its your code html markup and semantics. You can replace the
<div>
that wraps each card with<article>
you can wrap the paragraph with the quote with the tag<blockquote>
this way you'll wrap each block of element with the best tag in this situation. Pay attention that<div>
is only a block element without meaning.This article from Freecodecamp explains the main HTML semantic TAGS: https://www.freecodecamp.org/news/semantic-html5-elements/
✌️ I hope this helps you and happy coding!
Marked as helpful0@vjeanty02Posted about 2 years agoHello @correlucas, I appreciate your advice.
However, I'm a bit confused on the usage of <section> <article> and <div> tags. The problem is that when I use <section> some tell me <article> tag is better, I change to <article> others tell me <section> is better. And I change again, in the end I am told that the <div> tag is preferable when you are not sure of the tag to use.
I want to ask your opinion. Do you think the use of <section>, <article> and <div> tags is a developer appreciation?
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord