Design comparison
Solution retrospective
This was slightly tricky. Would love some feedback from fellow developers :)
Community feedback
- @Bishalsnghd07Posted 9 months ago
Hi, @h4sitha
You Design presence of mind is quite impressive, I like it❤️
But, I have one suggestion for you. Never use height in body, always use
min-height
instead ofheight
. Due, to this your layout will break and it happens in smaller screen, see your top part is breaking. Do, this change and everything is perfect.Amazing work and hope this suggestion will help you.
Marked as helpful1@h4sithaPosted 9 months ago@Bishalsnghd07 Thank you so much for your comment and the advice!
I didn't know how to fix that and honestly, I didn't think that was a big issue because it worked fine when I viewed the page on my phone.
0@Bishalsnghd07Posted 9 months ago@h4sitha In your mobile screen top part of your layout looks fine? Didn't cutting?
0@h4sithaPosted 9 months ago@Bishalsnghd07 Ah yes you're right. My bad. I didn't check this one using my phone. I checked pages, the projects I previously did, in which I used the height instead of min-height and they were working fine.
1
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord