Design comparison
Community feedback
- @CodeWithAlaminPosted almost 2 years ago
Hi Mallory👋 Great job on completing this challenge! 🥳
I would like to share a few suggestions on this solution if you don't mind.
-
Use semantic HTML tags whenever possible. For example, the
header
andmain
tags could be used to enclose the header and main content of the webpage, respectively. This can make the structure of the page easier to understand and maintain. -
Consider using CSS grid or flexbox to create a more flexible layout. Currently, the page is using the
display: grid
property on thebody
element to center the content. This can work well in some cases, but using grid or flexbox can give you more control over the layout and make it easier to create responsive designs that adapt to different screen sizes. -
Use descriptive, meaningful class names. The class names used in the CSS file, such as
header__title
andrating__star
, are relatively short and may not always be self-explanatory. Using more descriptive class names can make the code easier to understand and maintain, especially for someone who is new to the project. For example,header__title
could be changed topage-header__title
to make it clear that it is related to the page header.
Overall, this is a very well done solution to the challenge. Great job!
I hope this feedback was helpful. 😊 Keep up the good work!👍
2 -
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord