Social Proof Section with Sass and BEM

Community feedback

• 

  P

  tediko•6,680

  @tedikoPosted over 3 years ago

  Hello, Nikita! 👋

  Well done on this challenge! Here's a few things I'd suggest you to take a look at:

  • Change the alt attributes for the .card images/avatars, as they don't add any extra context for screen reader users. Since your images are decorative your alt text should be provided empty (alt="") so that they can be ignored by assistive technologies.
  • Take a look at my feedback in your previous solution. I think you didn't notice I commented 😅 You did excatly same here where you have only media queries for mobile and desktop, nothing between.
  • Use Responsive Design Mode to see how your website behaves on different devices. To toggle it press CTRL+SHIFT+M on Firefox, and CTRL+SHIFT+C on Chrome.

  Keep up the good work! 💪

  1

  ---

  

  Nikita•175

  @WidePeepoHappyPosted over 3 years ago

  @tediko Hi! I have seen your comment on my previous solution, but haven't got the time to change it yet. And for this one i thought I would make it responsive until it reaches mobile size. What sizes would you recommend making queries at? Thank you for your feedback my solutions :)

  0

  

  P

  tediko•6,680

  @tedikoPosted over 3 years ago

  @WidePeepoHappy Take a look at this graphic.

  0

  

  Nikita•175

  @WidePeepoHappyPosted over 3 years ago

  @tediko worked on this one too, should look better now

  0
• 

  Agata Liberska•3,995

  @AgataLiberskaPosted over 3 years ago

  Hi there, well done on this challenge, it looks great! The only thing I noticed is that when I open the page on my desktop, I get a scroll bar and the bottom background image doesn't quite reach the bottom of the page. (If you're on slack, I can send you a screenshot of what I see).

  I guess you could also include some more semantic HTML elements, like main or section, and article for the reviews.

  1