Design comparison
Solution retrospective
Any feedback are appreciated :)
Community feedback
- @AgataLiberskaPosted over 3 years ago
Hi @AchmadAkif! Well done on this challenge, looks really nice! Just small details that could be corrected to polish it up:
-
when I open the page on my screen, the edges of the top section don't align with the edges of the bottom section. One thing you could do to fix that is to set 'justify-content: space-between' on your cards container so that the cards reach the edges of it. I would also set a max-width on the div with the class '.container' so that things don't stretch too much.
-
On desktop layout, I think it would be good if the whole thing could be centered on the screen. It's very easy to do using grid or flexbox on your body element.
-
Again on desktop, the bottom of the background image doesn't quite reach the bottom of the screen. I think that's because the margin of the
.container
is pushing the top edge of the body element down and that is causing some issues. Try changing that margin to padding instead. This should also make sure that you get space between the last card and the bottom of the viewport in mobile - right now the margin is collapsing, at least in my browser.
Hope this helps, happy coding! :)
0 -
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord