Social proof section with Flexbox, mobile first

Community feedback

• 

  Melvin Aguilar 🧑🏻‍💻•61,140

  @MelvinAguilarPosted 11 months ago

  Hello there 👋. Good job on completing the challenge !

  I have some suggestions about your code that might interest you.

  • It's a bit unusual to use a media query with such a high breakpoint to change the max-width. According to some solutions I see, it's very common to set these styles directly on the container: max-width: 1270px; margin-inline: auto. I also feel that 1270px is too large of a breakpoint for switching between desktop and mobile screens.

  • Regarding the issue of not seeing the background image until the bottom, it's because the element doesn't have a height. Without height, the image won't know the bottom right position. As mentioned, using min-height: 100vh will fix this.

  I hope you find it useful! 😄

  Happy coding!

  Marked as helpful

  1
• 

  Daniel 🛸•44,310

  @danielmrz-devPosted 11 months ago

  Hello @mbd89!

  Your project looks great!

  I have just one suggestion:

  • There's a vertical scrollbar appearing on your project. If you remove all the body padding and add min-height: 100vh; to it, the scrollbar disappears and your project will be centered.

  The screenshots are not always completely accurate, so I wouldn't worry about that. On my screen, your project looks excellent!

  I hope it helps!

  Other than that, you did a great job!

  Marked as helpful

  0