Social proof section with CSS flexbox

Community feedback

• 

  T

  ApplePieGiraffe•30,545

  @ApplePieGiraffePosted about 4 years ago

  Hey, Yemisrach15! 👋

  Great job on this challenge! It matches the original design very nicely! 🙌

  In addition to mrjayy5's feedback, I suggest,

  • Allowing the height body of the page to scale to the height of the viewport so that it fills up the entire screen and the background SVG to the right sticks to the bottom of the screen (even on large screens).

  Keep coding (and happy coding, too)! 😁

  1
• 

  Miquel•275

  @mrjayy5Posted about 4 years ago

  Hi Yemisrach, I love your work 👏🏼!

  You have a great eye for detail I can see 😉! I like to see how you handled the responsiveness, great work!

  1. I think you should try to make a .star element in your CSS and replace the img's with <div class='star-icon'></div>. This way the page only need to download the SVG once. But you still have to insert the element 5 times.

  2. I think the HTML is pretty clean. Good indent, so it's nice to read. You should consider using Sass. It can reduce the lines of CSS significantly and it's easier to maintain. So especially for bigger projects it's a must have!

  Keep on coding 🔥!

  1

  ---

  

  Yemisrach•1,430

  @Yemisrach15Posted about 4 years ago

  Thank you @mrjayy5. I used PerfectPixel chrome extension😁

  1. Yep you're right. Very insightful. I didn't think about that but will definitely use that in the future.

  2. I've never used Sass. I'll look into that if I plan to do big projects as you said.

  0

  

  Miquel•275

  @mrjayy5Posted about 4 years ago

  @Yemisrach15 it might be usefull to start with Sass on small project so you can get the hang of it right away. It might seems scary at first, but its really easy. 1 small project in Sass will give you confident working with Sass! And you will never go back again haha!

  1

  

  Yemisrach•1,430

  @Yemisrach15Posted about 4 years ago

  @mrjayy5 True. I'll try to. Thanks for the boost.

  0