Design comparison
Solution retrospective
Mobile-first coding might have backfired for this one; a few behaviours I couldn't quite wrangle when translating to desktop (most notably the ratings having a gap I couldn't reduce to fit the design spec). If anyone can figure out why this is the case I would appreciate it.
Community feedback
- @correlucasPosted about 2 years ago
👾Hello @BenjaminNicholasWells, Congratulations on completing this challenge!
Great code and great solution! I’ve few suggestions for you that you can consider adding to your code:
You did a really good work here putting everything together, something you can improve its your code html markup and semantics. You can replace the
<div>that wraps each card with<article>you can wrap the paragraph with the quote with the tag<blockquote>this way you'll wrap each block of element with the best tag in this situation. Pay attention that<div>is only a block element without meaning.This article from Freecodecamp explains the main HTML semantic TAGS: https://www.freecodecamp.org/news/semantic-html5-elements/
✌️ I hope this helps you and happy coding!
0
Please log in to post a comment
Log in with GitHub
Join our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord