Social proof section using HTML and SCSS
Design comparison
Solution retrospective
give me feedback
Community feedback
- @MasterDev333Posted almost 4 years ago
Great work @Muhammad. One suggestion, it would be better if you use background-image for rating stars. If you draw 4.2 or 4.5, you can't draw it with the current solution. You may use background-repeat for repeating stars and set the width of parent div to draw 4.2 or 4.5. Hope it helps. Happy coding~
0 - @axevldkPosted almost 4 years ago
Hi, @Muhammad Ahmad Hassan ~ I have studied your work, and good work so far ~ Here are some of my opinions.
-
You used image elements for background images, but that's not appropriate in such cases. I hope you to use pseudo elements or background-image css properties.
-
You used main tag for header part, but it would better to wrap all of header and card section inside it. <main> tag is used for wrapping whole content conventionally.
-
Also you set padding to body element. I suggest you to use
max-width: 1440px;
to sub container of body.
Hope my words can help you even a bit. Happy coding ~ ✨
0 -
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord