Design comparison
Solution retrospective
Hey, just finished my second challenge here. Any feedback is welcome!
1.What mistakes do I have?
Thanks <3
Community feedback
- @arturpawlowski5Posted over 3 years ago
Hi Joseph,
Your Design look really nice. I looked in your Code and I have some ideas you can make it better.
-
Based on Style Guide size for the Desktop should be 1440px. I see in your Code
.main
that you used1300px
. -
.main
can be flexbox withflex-direction: column
. This way your<div class="main__top">
and<div class="main__bottom">
can be inside this flexbox. -
.card
you usemargin: 4.3rem 0;
thenmargin: 2rem 2rem;
thenmargin: 0 0 1rem 0;
. This is little not consistent. Try to make right/left margin for each .card and extra top or bottom margin to move them. e.g. 01-margin: 0px 20px 0px;
, 02-margin: 20px 20px 0px;
, 03-margin: 40px 20px 0px;
. -
On mobile this part is not centered
<div class="asides"> <aside class="asides__aside"><span class="asides__aside-stars"></span>Rated 5 Stars in Reviews</aside> <aside class="asides__aside"><span class="asides__aside-stars"></span>Rated 5 Stars in Report Guru</aside> <aside class="asides__aside"><span class="asides__aside-stars"></span>Rated 5 Stars in BestTech</aside> </div>
Try to work with that to make Stars and Text centered on mobile.
I hope this will help you a little with your Design.
Happy Coding :-B
0@Joseph-dev22Posted over 3 years ago@arturpawlowski5 Thanks a lot, Artur. I will do in a moment.
0 -
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord